Mon. Oct 2nd, 2023

[ANSWERED] html – Javascript Link to Href maker not working

By

Nov 18, 2022 html, javascript

Solution 1 :

Your flink1 will always contain empty strings for href and innerText because your generate doesn’t update its value upon user input.

Move the variable definition inside generate call, and it’ll work as intended.

var text1 = document.getElementById("text1");
var link1 = document.getElementById("link1");
var input = document.getElementById("thetext");

function generate() {
  var flink1 = "<a href='" + link1.value + "'>" + text1.value + "</a>";
  input.value = flink1
}

input,
textarea {
  width: 100%;
  height: 50px
}

<textarea id="thetext" class=""></textarea>
<br/><br/>
<input id="link1" placeholder="link"></input><br/><br/>
<input id="text1" placeholder="link title"></input><br/><br/>
<button id="" onclick="generate()">Generate</button>

Solution 2 :

This is your answer.

function generate() {
var text1 = document.getElementById("text1");
var link1 = document.getElementById("link1");
var input = document.getElementById("thetext");
var flink1 = "<a href='" + link1.value + "'>" + text1.value + "</a>";
input.value = flink1;
}

input,
textarea {
  width: 100%;
  height: 50px
}

<textarea id="thetext" class=""></textarea>
<br/><br/>
<input id="link1" placeholder="link"></input><br/><br/>
<input id="text1" placeholder="link title"></input><br/><br/>
<button id="" onclick="generate()">Generate</button>

Problem :

I’m trying to make a simple link to html maker, but the thing is variables aren’t working

var text1 = document.getElementById("text1");
var link1 = document.getElementById("link1");
var input = document.getElementById("thetext");
var flink1 = "<a href='" + link1.value + "'>" + text1.value + "</a>";

function generate() {
  input.value = flink1
}

input,
textarea {
  width: 100%;
  height: 50px
}

<textarea id="thetext" class=""></textarea>
<br/><br/>
<input id="link1" placeholder="link"></input><br/><br/>
<input id="text1" placeholder="link title"></input><br/><br/>
<button id="" onclick="generate()"></button>

Can anyone say what’s the issue

Comments

Comment posted by Steve Tomlin

you need to wrap your javascript in a script tag

Comment posted by Daniel Beck

Put all of that javascript inside the

Comment posted by Justinas

You are building

Comment posted by Daniel Beck

(The missing script tag was only because they slightly mangled the format for a stack overflow snippet, guys)

Comment posted by jsfiddle.net/toj9fmg7/1

as @Justinas said.you are building flink1 before user even entered anything

By

Related Post

[ANSWERED] html – I can’t get my carousel buttons to respond bootstrap 4

Nov 20, 2022

[ANSWERED] javascript – Locomotive Scroll not working with Vue.js when having to load images on page

Nov 20, 2022

[ANSWERED] html – How to import/veiw STL files in a wordpress website?

Nov 20, 2022